Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'any' with a generic in Set (Close #3337) #3338

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

kubk
Copy link
Collaborator

@kubk kubk commented Mar 17, 2022

Related issue: #3337

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2022

🦋 Changeset detected

Latest commit: 56a2e80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kubk kubk requested a review from urugator March 17, 2022 07:13
set.has("1")
// @ts-expect-error
set.delete("1")
})
Copy link
Collaborator Author

@kubk kubk Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice feature of ts-expect-error is that it throws if there is no TS error on the next line (unlike ts-ignore)

@kubk
Copy link
Collaborator Author

kubk commented Mar 17, 2022

@urugator Done

@urugator urugator merged commit 767baff into main Mar 17, 2022
@urugator
Copy link
Collaborator

Thank you!

@github-actions github-actions bot mentioned this pull request Mar 17, 2022
@kubk kubk deleted the set-replace-any-with-generic branch July 18, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants