Avoid creation of irrelevant temporary files on Windows #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
tonistiigi
approved these changes
Apr 27, 2020
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 30, 2020
full diff: moby/buildkit@b26cff2...59e305a - moby/buildkit#1469 Avoid creation of irrelevant temporary files on Windows - backport of moby/buildkit#1462 for the docker-19.03/v0.6 branch Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 5, 2020
full diff: moby/buildkit@b26cff2...59e305a - moby/buildkit#1469 Avoid creation of irrelevant temporary files on Windows - backport of moby/buildkit#1462 for the docker-19.03/v0.6 branch Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 63841af153595a18b66ba125d4b590e1e9e90a8e Component: engine
|
Was it pushed also to Docker Desktop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binfmt_misc package creates temporary files containing alternate arch binaries to check if qemu binfmt support is enabled for them.
On Windows, it creates those file as well, even if there is no way those files can get executed on Windows as they are Linux binaries.
This PR avoids these unnecessary file creations on Windows, to avoid downstream projects such as dockerd to create those files on Windows.