Use exclusive root pools if a CA cert file is specified in the daemon #33182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM on green |
Signed-off-by: Ying Li <ying.li@docker.com>
|
(sorry misspelled a word in a comment, fixed that :)) |
|
LGTM |
cpuguy83
added
priority/P0
|
CVE-2018-12608 was assigned to this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33173.
#31705 added
ExclusiveRootPools: truewhen setting up the docker client configuration, but this should also be applied to the daemon.If a file containing CAs for validating clients is provided, only the certs used in that file should be used to validate client connections, and not both the certs in that file and the system root certs.
If the union of the system certs and the provided CA certs is desired, the additional CA certs should be added to the system pool, or the system certs added to the provided CA file.
cc @dmcgowan @thaJeztah
Also cc @diogomonica for visibility