layer: remove metadata store interface #36504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layer metadata storage has not been implemented outside of the layer store and will be deprecated by containerd metadata storage. To prepare for this and freeze the current metadata storage, remove the exported interface and make it internal to the layer store. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
thaJeztah
added
roadmap
status/2-code-review
area/images
and removed
status/0-triage
labels
|
ping @tonistiigi @dnephin PTAL |
tonistiigi
approved these changes
Mar 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #36504 +/- ##
=========================================
Coverage ? 34.67%
=========================================
Files ? 613
Lines ? 45405
Branches ? 0
=========================================
Hits ? 15742
Misses ? 27604
Partials ? 2059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layer metadata storage has not been implemented outside of the layer store and will be deprecated by containerd metadata storage. To prepare for this and freeze the current metadata storage, remove the exported interface and make it internal to the layer store.
Note: the original intent of exposing this interface was to make it possible in the future to use a transactional datastore rather than rely on keeping files on disk in sync. This ended up being achieved in containerd, which does not make use of this interface. This refactoring will also help in transitioning graph drivers to snapshotters by allowing shared functionality (e.g. diff, mount) to be pulled up into the layer store (without making confusing interface changes) before moving to containerd.