Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and incorrect test.retries(n) #4611

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Mar 26, 2021

Description of the Change

We remove test.retries(n) from our interfaces common, bdd, tdd, qunit.
This function has never been used/implemented correctly as shown by coverall's excited reaction. Furthermore the signature is weird and somewhat incomplete.

This PR does not affect:

  • this.retries(n) within suites and tests
  • it(title, fn).retries(n)

@juergba juergba added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Mar 26, 2021
@juergba juergba self-assigned this Mar 26, 2021
@juergba juergba requested review from boneskull and a team and removed request for boneskull March 26, 2021 15:46
@juergba juergba merged commit d7ed5c2 into master Mar 30, 2021
@juergba juergba deleted the juergba/retries branch March 30, 2021 14:19
@juergba juergba added this to the next milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants