Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use toFixed(2) for rotate.z #1340

Merged
merged 5 commits into from
Sep 26, 2024
Merged

fix: use toFixed(2) for rotate.z #1340

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3de933
fix: sometimes the rotation is too huge to encode
moe-moe-pupil Sep 26, 2024
94a6cb4
Merge branch 'master' into feat-stream
moe-moe-pupil Sep 26, 2024
0b2d4d7
Revert "fix: sometimes the rotation is too huge to encode"
moe-moe-pupil Sep 26, 2024
049cdd3
fix: toFixed(2) for rotate.z
moe-moe-pupil Sep 26, 2024
725b621
chore: add comment
moe-moe-pupil Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/gameClasses/Item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,9 @@ var Item = TaroEntityPhysics.extend({
}
// for client-side, translate+rotate is handled in entitiesToRender.ts
self.translateTo(x, y);
self.rotateTo(0, 0, rotate);
//FIXME: there is one very secret operation, the rotate.z is a string before I(moethun) did any update
// but somehow toFixed(2) could let it stream the correct position rather than (0, 0, 0)
self.rotateTo(0, 0, parseFloat(rotate).toFixed(2));
// added check so braains works and ai item rotation also works
} else if (!taro.physics) {
// for updating physics body of this item
Expand Down
Loading