Upgrade rust toolchain to 2022-11-20 #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
force-pushed
the
rust-toolchain-2022-11-20
branch
from
ae253dc
to
f3a4997
Compare
celinval
reviewed
Nov 22, 2022
| @@ -176,7 +176,9 @@ impl<'tcx> ProjectedPlace<'tcx> { | |||
| goto_expr, expr_ty, ty_from_mir | |||
| ); | |||
| warn!("{}", msg); | |||
| debug_assert!(false, "{}", msg); | |||
| // TODO: this assertion fails on firecracker with the rust 2022-11-20 toolchain | |||
| @@ -53,6 +53,7 @@ impl<'tcx> GotocCtx<'tcx> { | |||
| self.current_fn().mir().var_debug_info.iter().find(|info| match info.value { | |||
| VarDebugInfoContents::Place(p) => p.local == *l && p.projection.len() == 0, | |||
| VarDebugInfoContents::Const(_) => false, | |||
| VarDebugInfoContents::Composite { .. } => todo!(), | |||
There was a problem hiding this comment.
Can you please create an issue and add more details there? I wonder if we should really crash in this case.
celinval
reviewed
Nov 28, 2022
4 tasks
zhassan-aws
force-pushed
the
rust-toolchain-2022-11-20
branch
from
e33a5f0
to
fe84d4c
Compare
celinval
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upgrade rust toolchain to 2022-11-20.
Resolved issues:
Resolves #1923
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
This causes a debug_assert in
ProjectPlace::try_newto fail. I've disabled the debug assert which will make codegen produce acodegen_unimplemented.Testing:
How is this change tested? Existing regressions
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.