RFC: The kani::should_panic attribute
#2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Mar 6, 2023
adpaco-aws
changed the title
kani::should_fail attributekani::should_panic attribute
karkhaz
reviewed
Mar 20, 2023
robdockins
reviewed
Mar 20, 2023
|
Addressed comments on the PR and from our discussion yesterday:
|
zhassan-aws
approved these changes
Mar 22, 2023
4 tasks
karkhaz
approved these changes
Mar 23, 2023
4 tasks
adpaco-aws
added a commit
that referenced
this pull request
Jan 12, 2024
…tions (#2967) This PR is the next step to rework/introduce the `should_panic`/`fail_uncoverable` options as global conditions. Until now, we haven't had a concrete proposal to do so other than the implementation in #2532. This PR presents one for each option in their respective RFCs. I'd like to agree on this design before starting the code review for #2532. Related to #1905 #2272 #2299 #2516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Users may want to express that a verification harness should panic.
This RFC proposes a new harness attribute
#[kani::should_panic]that informs Kani about this expectation.Rendered preview here.
Resolved issues:
Related #600
Call-outs:
Testing:
How is this change tested? N/A
Is this a refactor change? N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.