Upgrade toolchain to nightly-2023-03-09 #2293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
reviewed
Mar 10, 2023
| @@ -6,10 +6,10 @@ | |||
|
|
|||
| use crate::kani_middle::reachability::{collect_reachable_items, filter_crate_items}; | |||
| use crate::kani_middle::stubbing; | |||
| use crate::kani_middle::ty::query::query_provided::collect_and_partition_mono_items; | |||
There was a problem hiding this comment.
This change looks a bit odd. Isn't this importing collect_and_partition_mono_items from rustc_middle? If so, why is it referring to crate::kani_middle?
tautschnig
force-pushed
the
issue-2283-toolchain
branch
from
9e4d1cb
to
0cfe538
Compare
|
I have rebased the branch to include the CBMC 5.79.0 update to make sure this dependency is sorted out (but obviously we are currently failing well before reaching CBMC). I will look into those failures. |
tautschnig
force-pushed
the
issue-2283-toolchain
branch
3 times, most recently
from
9db9cb5
to
30eb983
Compare
Upstream PRs that require local changes: - Switch to EarlyBinder for type_of query rust-lang/rust#107753 - Factor query arena allocation out from query caches rust-lang/rust#107833 Co-authored-by: Qinheping Hu <qinhh@amazon.com>
- Introduce -Zterminal-urls to use OSC8 for error codes rust-lang/rust#107838 - Unify validity checks into a single query rust-lang/rust#108364 - Rename interner funcs rust-lang/rust#108250 - Optimize mk_region rust-lang/rust#108020 - Clarify iterator interners rust-lang/rust#108112
tautschnig
force-pushed
the
issue-2283-toolchain
branch
from
30eb983
to
53e07cc
Compare
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Apr 25, 2023
This is related to the performance degradation we are seeing in the toolchain upgrade: model-checking#2293
4 tasks
celinval
added a commit
that referenced
this pull request
Apr 28, 2023
Use the overflow result operations instead of doing the math twice. This is related to the performance degradation we are seeing in the toolchain upgrade: #2293 Co-authored-by: Michael Tautschnig <tautschn@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upgrade our toolchain to
nightly-2023-03-09. The changes here are related to the following changes:-Zterminal-urlsto use OSC8 for error codes rust-lang/rust#107838targetinstead ofmachinefor mir interpreter integer handling. rust-lang/rust#108047EarlyBinderfortype_ofquery rust-lang/rust#107753mk_regionrust-lang/rust#108020Resolved issues:
Resolves #2283
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.