Mojo::Date: epoch can be a negative number #1079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Mojo::Date when used with negative numbers as epoch
Motivation
I found the issue when representing birth dates with Mango::Time objects - a date before the epoch like 1965-12-21 would emit uninit warnings and end up represented as Jan 1, 1970. This comes from https://github.com/oliwer/mango/blob/master/lib/Mango/BSON/Time.pm#L12 which in turn points to Mojo::Date code https://github.com/kraih/mojo/blob/master/lib/Mojo/Date.pm#L25
For example, running the test included in this PR with the code in master gives the output
References
None