Improve Code Contrast in PODRenderer and Project Site #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A theme with more contrast might make sense, but i don't like the removal of the background. 👎 |
|
I agree with kraih here, support the contrast part, not the removal of the background. 🌮 |
|
I don't have any opinion. Per our usual convention, this PR hasn't reached consensus and has since "aged out". I think we are in agreement that style is up for discussion so continue on IRC and/or in forks and please open a new PR for the next iteration. Thanks! |
|
We now have a theme with a little more contrast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the colors in prettified code sections don't meet a minimum suggested contrast of 4.5:1 for accessibility, this PR bumps the colors in the light theme -- used in PODRenderer and the project website but not debug pages -- to that minimum. A second commit removes stripes.png, which is 1px white/8% gray vertical stripes that hamper readability and can cause artifacts on some displays, for a solid average of the two. The dark theme on the debug page doesn't have this issue.
Motivation
Accessibility is important for new and current users and we should take complaints about it very seriously. Not everyone has good sight, or will stay young, or can correct their vision, or afford the nicest equipment. Comments like "con crit please" and "wtf did you do to your DE" are unwelcoming, inconsiderate, etc.
References
http://code-of-conduct.mojolicious.org/
https://irclog.perlgeek.de/mojo/2017-09-02#i_15107586
https://irclog.perlgeek.de/mojo/2017-09-03#i_15107708
Rendered Changes
Firefox 52 ESR, Windows 10, 96 dpi:
