Add log shortcut. #1270
Closed
Add log shortcut. #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthorsen
reviewed
Oct 8, 2018
There was a problem hiding this comment.
I'm very positive to this change, but I was wondering if it should've been in in Mojolicious::Plugin::DefaultHelpers instead? My reasoning is that there might be users out there that has already added their own "log" helper, and I that won't be called after this change.
| =head2 log | ||
|
|
||
| Shortcut for app->log. Gives you the L<Mojolicious> application log object, | ||
| usually a L<Mojo::Log> object. |
There was a problem hiding this comment.
Seems like this lacks the normal call/return examples above the text.
|
Yea, this change kills log helpers. |
|
Thanks for the feedback, closing this PR and will reopen it as a new PR with a branch from my fork, as a helper. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a log shortcut to Mojolicious::Controller,
and updates guides and helpers to use it
Writing $self->app->log over and over feels tedious, this
PR makes Mojolicious more fun to use ;)
As discussed on IRC.