added progress notifications to Mojo::IOLoop::Subprocess #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Nov 6, 2018
lib/Mojo/IOLoop/Subprocess.pm
Outdated
| @@ -10,6 +10,7 @@ use Storable; | |||
| has deserialize => sub { \&Storable::thaw }; | |||
| has ioloop => sub { Mojo::IOLoop->singleton }, weak => 1; | |||
| has serialize => sub { \&Storable::freeze }; | |||
| has _progress_writer => undef, weak => 1; | |||
There was a problem hiding this comment.
We don't use private attribute accessors. Why do you need to weaken the reference?
There was a problem hiding this comment.
I weakened the reference thinking that would allow the pipe to disappear once ->run completes (but before $subprocess goes out of scope), and thus save on resources. Is there something wrong with that thinking?
kraih
reviewed
Nov 6, 2018
lib/Mojo/IOLoop/Subprocess.pm
Outdated
| $snippet =~ s/\A$length\-//; | ||
| my $args = $self->deserialize->($snippet); | ||
| $self->emit(progress => @$args); | ||
| } |
There was a problem hiding this comment.
This block is in need of some golfing, it seems way too verbose. 😉
There was a problem hiding this comment.
pos can replace the length($length) + 1
my ($length, $s) = (($progress_buffer =~ m/\A(\d+)\-/gc), pos($progress_buffer));
defined $length or last;
length($prog_buffer) >= ($length += $s) or last;
my $args = $self->deserialize->(substr substr($progress_buffer, 0, $length, ''), $s);
$self->emit(progress => @$args);
|
Squash your commits. |
kraih
reviewed
Nov 7, 2018
lib/Mojo/IOLoop/Subprocess.pm
Outdated
| # Child | ||
| return $self->$parent("Can't fork: $!") | ||
| unless defined(my $pid = $self->{pid} = fork); | ||
| unless ($pid) { | ||
| close $progress_reader; |
There was a problem hiding this comment.
Why does $progress_reader need to be closed manually, but not $reader?
jberger
approved these changes
Nov 7, 2018
|
lgtm 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added 'progress' method and event to Mojo::IOLoop::Subprocess, in accordance to kraih's specifications. Includes test, but no documentation just yet.
Motivation
This pull-request comes after an issue for its implementation was written in the mojo project
References
issue #1285