Wait for promise to resolve regardless of loop being stopped #1315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that
wait
will keep running the loop until the promise is no longer pending.Motivation
Calling
wait
can result in a still-pending promise even if the loop is not running, as anything may stop the loop. This small change ensures that it will not return while the promise is pending, which is the documented behavior and user expectation. This is also important for the proposedget
method(s), to ensure it does not return before the results are available.References
Prior art: the implementations of
await
andget
in Future event loop subclasses will loop until the Future is no longer pending.