Fall back to normal constructor if hash style arguments are provided

[marcusramberg]

Summary

Fall back to old behavior if more than one argument or hashref is given as argument

Motivation

Maintain old behavior

References

As discussed on IRC.

[marcusramberg]

As discussed on IRC we should probably either add a deprecation notice to this or change clone and the test back to use the constructor arguments instead of the setter. I prefer the latter.

[kraih]

What are the use cases for this feature? (Can't check right now, but i'm fairly sure we have no constructors yet that extend the Mojo::Base argument variations, so use cases need to be strong)

[marcusramberg]

@kraih We do have a lot of constructors with special behavior for single argument. Like

lib/Mojo/URL.pm:55:1:sub new { @_ > 1 ? shift->SUPER::new->parse(@_) : shift->SUPER::new }

[marcusramberg]

My main concern is maintaining backwards compat, so I'm fine with adding this with a deprecation notice as well to avoid breakage until upstreams have had time to adjust.

[kraih]

@marcusramberg That's not the same at all. There is no attribute handling in Mojo::URL::new, which is very special.

[Grinnz]

What's the status of this? Downstream modules are still broken in the meantime :(

[jhthorsen]

I'm 👍 on merging this, but maybe we should probably also add a deprecation warning at the same time if the if kicks in.

[Grinnz]

@marcusramberg Could you add a deprecation notice to the PR?

[marcusramberg]

@Grinnz done. @mojolicious/core can we have a couple of more votes?