Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add range() to Mojo::Collection #1361

Closed
wants to merge 1 commit into from
Closed

Add range() to Mojo::Collection #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion lib/Mojo/Collection.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ sub new {
return bless [@_], ref $class || $class;
}

sub range {
my $self = shift;
my ($begin, $end)
= map { my $i = $_ < 0 ? @$self + $_ : $_; $i < 0 ? 0 : $i }
($_[0] // 0, $_[1] // int @$self);
return $self->new if $begin >= @$self || $end == 0;
$end = @$self - 1 if $end >= @$self;
return $self->new(@$self[$begin .. $end]);
}

sub reduce {
my $self = shift;
@_ = (@_, @$self);
Expand Down Expand Up @@ -96,7 +106,7 @@ sub uniq {
my ($self, $cb) = (shift, shift);
my %seen;
return $self->new(grep { !$seen{$_->$cb(@_) // ''}++ } @$self) if $cb;
return $self->new(grep { !$seen{$_ // ''}++ } @$self);
return $self->new(grep { !$seen{$_ // ''}++ } @$self);
}

sub with_roles { shift->Mojo::Base::with_roles(@_) }
Expand Down Expand Up @@ -281,6 +291,26 @@ passed to the callback, and is also available as C<$_>.

Construct a new array-based L<Mojo::Collection> object.

=head2 range

my $new = $collection->range($begin, $end);
my $new = $collection->range(0, 2);
my $new = $collection->range(-4, -1);
my $new = $collection->range;
my $new = $collection->range;

Creates a new collection with the portion of the collection from C<$begin> to
C<$end> - C<$end> not included. C<$begin> will default to "0" unless specified,
and C<$end> will default to the L</size> of the collection. If C<$begin> is
greater than the L</size> of the collection, then an empty collection will be
returned. C<$begin> and C<$end> can also be negative, indicating an offset from
the end of the collection.

# "C D E"
c('A', 'B', 'C', 'D', 'E')->range(2)->join(' ');
c('A', 'B', 'C', 'D', 'E')->range(2, -1)->join(' ');
c('A', 'B', 'C', 'D', 'E')->range(-3, -1)->join(' ');

=head2 reduce

my $result = $collection->reduce(sub {...});
Expand Down
16 changes: 15 additions & 1 deletion t/mojo/collection.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@ is $collection->map('reverse')->map(join => "\n")->join("\n"),
is $collection->map(join => '-')->join("\n"), "1-2-3\n4-5-6\n7-8-9",
'right result';

# range
$collection = c(1 .. 5);
is_deeply $collection->range(0)->to_array, [1 .. 5], 'right result';
is_deeply $collection->range(0, 0)->to_array, [], 'right result';
is_deeply $collection->range(0, 4)->to_array, [1 .. 5], 'right result';
is_deeply $collection->range(0, 10)->to_array, [1 .. 5], 'right result';
is_deeply $collection->range(4)->to_array, [5], 'right result';
is_deeply $collection->range(5)->to_array, [], 'right result';
is_deeply $collection->range(5, 10)->to_array, [], 'right result';
is_deeply $collection->range(-1, -1)->to_array, [5], 'right result';
is_deeply $collection->range(-10, -7)->to_array, [], 'right result';
is_deeply $collection->range(-10, 10)->to_array, [1 .. 5], 'right result';
is_deeply $collection->range(-3)->to_array, [3 .. 5], 'right result';

# reverse
$collection = c(3, 2, 1);
is_deeply $collection->reverse->to_array, [1, 2, 3], 'right order';
Expand Down Expand Up @@ -140,7 +154,7 @@ $collection = c(qw(Test perl Mojo));
is_deeply $collection->sort(sub { uc(shift) cmp uc(shift) })->to_array,
[qw(Mojo perl Test)], 'right order';
$collection = c();
is_deeply $collection->sort->to_array, [], 'no elements';
is_deeply $collection->sort->to_array, [], 'no elements';
is_deeply $collection->sort(sub { $a cmp $b })->to_array, [], 'no elements';

# slice
Expand Down