Update default SSL/TLS key to support TLS 1.2+ #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the default key used for local HTTPS server testing to support TLS 1.2+. An RSA key of 4096 bits is created, with SHA256 digest support, with duration and Common Name as before. As of Debian 10 "buster" the default system supported TLS level is 1.2, and as a result, the current server.crt certificate using RSA:1024 with SHA1 digest support is not supported and will no longer work "out of the box". With Apple, Google, Microsoft, and Mozilla announcing plans to deprecate TLS 1.0 and 1.1 in early 2020, and Linux distributions updating their baseline TLS support, it seems prudent to update this key so that it continues to work for developers.
|
I'm positive to updating the key to TLS 1.2+, but I'm negative to accept a new cert via a PR from someone who's not in the core team. Please correct me if I'm wrong in considering that a security concern. |
|
Agreed, someone from the team has to generate the new cert. |
|
Ack. Would you like me to close this PR and open a regular issue (with the relevant tags)? |
|
@knowledgejunkie I suppose that would make sense, thanks. |
|
Thanks for the report. I've updated the certificate. 59b409c...2343209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the default key used for local HTTPS server testing to
support TLS 1.2+. An RSA key of 4096 bits is created, with SHA256
digest support, with duration and Common Name as before.
Motivation
As of Debian 10 "buster" the default system supported TLS level is 1.2,
and as a result, the current server.crt certificate using RSA:1024 with SHA1
digest support is not supported and will no longer work "out of the box".
With Apple, Google, Microsoft, and Mozilla announcing plans to deprecate
TLS 1.0 and 1.1 in early 2020, and Linux distributions updating their
baseline TLS support, it seems prudent to update this key so that it
continues to work for developers.
References
https://groups.google.com/forum/#!topic/mojolicious/gjz-0uvUDLk
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929675