Restore promise map #1513
Closed
Restore promise map #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test coverage was lacking, getting in the way of new feature development" This reverts commit c949f57.
also adds comments and removes an intermediate promise
|
Note that it might be easier to review the comparison from before map was removed (and is restored in this PR): https://github.com/mojolicious/mojo/compare/3ca458038..restore_promise_map |
|
I'll also note that the weaken on the $loop is only needed because we close over $loop to return a rejection here. If "die" would work to "rethrow" the error then that weaken could be removed. |
|
It does not look good to me, |
|
Closing as superseded by a1f6d8a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restore Mojo::Promise::map and improve where there were concerns
Motivation
Because it was mostly ok, just needed some tweaks, and it is very useful
I have improved the test case to fail when the $proto promise wasn't cloned, however, I have then removed the $proto promise all together as an attempt to prevent warnings as we attempt to warn on unhandled rejected promises.