Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ entry for prototype error when not using signatures #1551

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

Grinnz
Copy link
Contributor

@Grinnz Grinnz commented Aug 10, 2020

Summary

Add a faq entry for the error received when trying to follow examples with signatures without enabling the signatures feature.

Motivation

Signatures from examples can get interpreted as prototypes and it's not immediately clear the signatures feature is required, especially for users not familiar with signatures or prototypes.

References

jhthorsen
jhthorsen previously approved these changes Aug 10, 2020
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Grinnz
Copy link
Contributor Author

Grinnz commented Sep 5, 2020

Rephrased as suggested

Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works.

@kraih kraih requested a review from a team September 6, 2020 20:35
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot merged commit faf2162 into master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants