Treat type_start in Mojolicious::Routes::Pattern as a character instead of a regex #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Nov 28, 2020
…ad of a regex The type_start attribute is meant to be a single character that delimits a placeholder name from its type. It was being passed directly to split and thus used as a regex, which means any regex metacharacters would break the parsing. Interpolate it with \Q to apply quotemeta to the character for use in split, and add tests for custom placeholder characters.
Grinnz
force-pushed
the
Grinnz/route_pattern_start_regex
branch
from
4c8b303
to
4f7dfd6
Compare
kraih
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The type_start character passed to split is currently being treated as a regex but it should be treated as a string to split on.
Motivation
The type_start attribute is meant to be a single character that delimits a placeholder name from its type. It was being
passed directly to split and thus used as a regex, which means any regex metacharacters would break the parsing.
Interpolate it with \Q to apply quotemeta to the character for use in split, and add tests for custom placeholder
characters.
References