Make config overrides work with Mojolicious::Lite #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
commented
Mar 10, 2021
There was a problem hiding this comment.
The overall change does look good I think. It seems like a pretty minimal change and solves the problem at hand in a good way. Consider this an approval, but I am holding off on actually approving until the thread asking for a better solution has been resolved (so as to avoid auto-merging prematurely). If you feel that the solution is OK as it is then I'll add my approval.
|
To prevent auto-merging a PR can also just be labeled work in progress. |
kraih
force-pushed
the
lite_config_override
branch
from
363d2df
to
2c3db3d
Compare
|
My main issue was bad encapsulation with the global variable, |
kraih
force-pushed
the
lite_config_override
branch
from
2c3db3d
to
f1af6ac
Compare
christopherraa
approved these changes
Mar 11, 2021
marcusramberg
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for #1406.