Taghelpers #18
Closed
Taghelpers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi sri!
Taghelpers update is done. It brings support for radiobuttons, disables params overwriting submit button value, and supports select, option and optiongroup via selection helper (to avoid clobbering select call).
We are still lacking the recommended default selection in radiobuttons and selections.
Perhaps we should also support button, but you can probably do that by reusing value in a second and much cleaner than myself.
Also, the selection code is horrible, twisted, spagetti etc. and will happily do disallowed recursive optiongroups. I suspect you will refactor heavily.
And I should have probably done some tests, but I am even worse on tests than on recursive traverals.