separate header shortcuts from other accessors #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathackeray
previously approved these changes
Feb 21, 2022
karenetheridge
force-pushed
the
ether/header-docs
branch
from
d213ff2
to
3d72f13
Compare
|
I will happily rebase this branch (and confirm that the changes are still accurate) if I can get this reviewed -- but I lack the permissions to tag the team for review. |
kraih
requested review from
a team,
marcusramberg,
kraih,
jberger and
Grinnz
Grinnz
previously approved these changes
Sep 19, 2023
karenetheridge
force-pushed
the
ether/header-docs
branch
from
3d72f13
to
3dd1c60
Compare
|
Rebased! |
mergify
bot
dismissed
Grinnz’s stale review
Pull request has been modified.
|
This pull request is now in conflicts. Could you fix it @karenetheridge? 🙏 |
karenetheridge
force-pushed
the
ether/header-docs
branch
from
3dd1c60
to
fbc99b4
Compare
This improves readability by making it easier to find the methods that aren't simply shortcuts to particular headers. I have confirmed that the headers listed in %NAMES exactly matches those in the pod, except for referer and referrer which have custom subs.
karenetheridge
force-pushed
the
ether/header-docs
branch
from
fbc99b4
to
fab6ab9
Compare
Grinnz
approved these changes
Sep 20, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves readability by making it easier to find the methods that aren't
simply shortcuts to particular headers.
I have confirmed that the headers listed in %NAMES exactly matches those in
the pod, except for referer and referrer which have custom subs.