-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exceptions to stash regardless of format #2065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still lgtm :)
6e2013b
to
c8f5869
Compare
@marcusramberg Had to make a change |
Its failing test now? |
@marcusramberg The tests pass, there is a bug with github workflow where it can't find the module if you look at the logs. Not sure.
|
@kraih Is this failing test my doing or is the |
d1871b4
to
c8f5869
Compare
c8f5869
to
c9ffe4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Make it easier to use exceptions, when exception format is not HTML
Motivation
It doesn't make sense for exceptions to be stored in the stash only if the format is HTML, instead it makes more sense, and is more consistent to store them in the stash for all formats
References
fixes #2048
I annihilated my branch on the other PR like a goof #2061 and github auto closed the PR because of it.