-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes cloudflare dependency from debug.html.ep #2078
Removes cloudflare dependency from debug.html.ep #2078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Commits need to be squashed, but lgtm :)
Replaces the font awesome icons with svg from: - https://icones.js.org/collection/fa6-regular - https://icones.js.org/collection/fa-brands
1833e99
to
aabbf57
Compare
Pull request has been modified.
Squashed |
Would be nice if you fixed the same issue in mojo.js too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
It appears the mouseover effect no longer works after the patch. |
Sent a fix in another PR #2079 |
Note that this PR breaks the license of the contributed 3rd party code, i have fixed this after the fact. Please be more careful in the future and respect license agreements. |
Summary
Removes cloudflare dependency from debug.html.ep and replaces the font awesome icons with svg from:
https://icones.js.org/collection/fa6-regular
https://icones.js.org/collection/fa-brands
Motivation
User complains that debug.html.ep hangs when he is offline and the issue seems to be because of external dependency on icons hosted on cloudflare CDN
References
Jun/18/2023 - $user: it might be an improvement to remove the line referencing cloudflare in debug.html.ep
Jun/18/2023 - kraih: then there's no font awesome, feel free to propose an alternative way to load it that doesn't make it hang though