Fixed: Mojo::DOM doesn't recognize end of comment (when it should) #2… #2080
Conversation
|
Please squash your commits. And split up individual bug fixes into separate PRs. |
|
And for bug fixes where specs are relevant, please reference the according spec sections. |
Should I close this PR and open another with a single squashed branch per PR? (Just noticed you already did reply back) |
You mean that I should include a comment with a link to the specific spec? |
|
Will open separate PRs |
| is $dom->tree->[7][1], '<', 'wrong comment'; | ||
| is $dom->tree->[8][1], "!-- bad idea -- HTML4 -- >\n", 'wrong comment'; | ||
|
|
||
| for ('<!-->', '<!--->', '<!-- --!>') { |
There was a problem hiding this comment.
$_ with such a wide scope is not good style.
There was a problem hiding this comment.
In fact, i don't like loops in tests at all, they only make errors harder to find because line numbers get so much less useful.
|
In its current form this seems like it would have been fine as one single squashed PR. |
…030.
#2030