Support for timezones in Mojo::Date #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although RFC2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3) is strict regarding GMT timezones, it notes, that "Recipients of date values are encouraged to be robust in accepting date values that may have been sent by non-HTTP applications". In my opinion, that says implementers SHOULD support consumption of non-gmt date values (for example in rfc-822), while they are not allowed to through out anything non-gmt like.
This patch supports literal time zones as specified in RFC-822 without the incorrectly introduced military timezones. This patch does not support alpha-numeric offsets.
Real world example: I discovered this issue when parsing BoingBoing.net RSS. RSS supports RFC-822, so I expected a RFC-2616 compliant parser to accept it, but it failed.