ioloop drops the connection because its active time isn't updated for buffered writes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a bug, buffering does not count as activity on a connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the "buffer" event is the correct solution, but at least you know what's "wrong". Client sends a request, server parses it, then handles it and writes the response using buffered writes. Buffered writes don't update the active time value so when the next ioloop iteration begins, the connection is being closed.
To reproduce you should run Morbo, set keepalive timeout to 1s and sleep in controller for a longer time. Such timeout is for inactive clients which don't send the requests, but not for inactive (or super-slow) servers. Browsers (clients) have their own timeout for that.