Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value of tx in Mojolicious::Controller #26

Closed
wants to merge 1 commit into from
Closed

Default value of tx in Mojolicious::Controller #26

wants to merge 1 commit into from

Conversation

sharifulin
Copy link
Contributor

Hi!

I added default value of tx in Mojolcious::Controller.
Please apply this patch :)

Thanks.

@kraih
Copy link
Member

kraih commented Sep 29, 2010

Why?

@sharifulin
Copy link
Contributor Author

I use Mojolicious controllers in standalone script (I use helpers, app config and render ep-templates).
My code:

use App;
use App::Controller;

my $self = App::Controller(app => App->new, tx => Mojo::Transaction::HTTP->new);

$self->helper(...);
$self->app->conf;
$self->render('not_found');

And tx param is unnecessary in this context.

@sharifulin
Copy link
Contributor Author

  • App::Controller->new( .. )

@kraih
Copy link
Member

kraih commented Sep 29, 2010

I guess adding it wouldn't hurt, even though the use case is questionable.

@sharifulin
Copy link
Contributor Author

Please add. Thanks.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants