-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth restarting for Morbo #421
Conversation
Hi, Cheers, |
@harvested Yes please! I just need to know if Morbo restarting still works on Windows. |
@kraih Ok, I will, but it will be done later today as it seems I don't have access to GitHub from work :| |
We still need Windows test results, but we've decided that we want the feature for Unix either way, and would just disable it on Windows if it doesn't work. |
Having everything merged into master should make testing a lot easier though, since you can just download the tarball. |
Will look into this later, same with github access here. On 27.11.2012, at 12:30, Sebastian Riedel notifications@github.com wrote:
|
We set MOJO_LISTEN to a custom value inside our main application script, and are now seeing cases where Morbo (apparently) tries to attach to the default 3000 port (which we use with another application), hence fails with "Can't create listen socket: Address already in use at .../Mojo/IOLoop.pm line 158." As soon as we stop that other application and free up port 3000, Morbo successfully starts with our custom ports from MOJO_LISTEN. Would you like me to open a new ticket for this issue? |
Adding to the comment above by tianon: it binds to port 3000 (but not listens) even though the MOJO_LISTEN is set to a different port. |
This issue is finished, the code has been merged and released to CPAN. If you believe it has introduced new bugs, please open a new issue. |
This change could eliminate the downtime between Morbo restarts, but it is not yet ready to be merged into master. So far it is completely untested on Windows and the name of the new Mojo::IOLoop method still has to be decided (currently
acceptor
).