Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth restarting for Morbo #421

Merged
merged 3 commits into from
Nov 27, 2012
Merged

Smooth restarting for Morbo #421

merged 3 commits into from
Nov 27, 2012

Conversation

kraih
Copy link
Member

@kraih kraih commented Nov 27, 2012

This change could eliminate the downtime between Morbo restarts, but it is not yet ready to be merged into master. So far it is completely untested on Windows and the name of the new Mojo::IOLoop method still has to be decided (currently acceptor).

@harvested
Copy link

Hi,
I just saw the tweet regarding Morbo and I'm willing to to some windows tests if you need me
Just write me and let me know

Cheers,
Andrei

@kraih
Copy link
Member Author

kraih commented Nov 27, 2012

@harvested Yes please! I just need to know if Morbo restarting still works on Windows.

@harvested
Copy link

@kraih Ok, I will, but it will be done later today as it seems I don't have access to GitHub from work :|

kraih added a commit that referenced this pull request Nov 27, 2012
Smooth restarting for Morbo
@kraih kraih merged commit 426428e into master Nov 27, 2012
@kraih
Copy link
Member Author

kraih commented Nov 27, 2012

We still need Windows test results, but we've decided that we want the feature for Unix either way, and would just disable it on Windows if it doesn't work.

@kraih
Copy link
Member Author

kraih commented Nov 27, 2012

Having everything merged into master should make testing a lot easier though, since you can just download the tarball.

@ghost
Copy link

ghost commented Nov 27, 2012

Will look into this later, same with github access here.

On 27.11.2012, at 12:30, Sebastian Riedel notifications@github.com wrote:

Having everything merged into master should make testing a lot easier though, since you can just download the tarball.


Reply to this email directly or view it on GitHub.

@tianon
Copy link
Contributor

tianon commented Nov 28, 2012

We set MOJO_LISTEN to a custom value inside our main application script, and are now seeing cases where Morbo (apparently) tries to attach to the default 3000 port (which we use with another application), hence fails with "Can't create listen socket: Address already in use at .../Mojo/IOLoop.pm line 158." As soon as we stop that other application and free up port 3000, Morbo successfully starts with our custom ports from MOJO_LISTEN. Would you like me to open a new ticket for this issue?

@yosifkit
Copy link

Adding to the comment above by tianon: it binds to port 3000 (but not listens) even though the MOJO_LISTEN is set to a different port.

@kraih
Copy link
Member Author

kraih commented Nov 29, 2012

This issue is finished, the code has been merged and released to CPAN. If you believe it has introduced new bugs, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants