Exception template clean up #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced div's with proper heading tags moved widths to CSS removed unneded tags and attributes
wrap mojolicious logo with anchor tag
all h2 headings are clickable and they toggle state of next sibling
.box have rounded corners (on all four corners)
|
Sorry it's still way too early for cleanup, we are still working on the actual look, basically all your patches are already broken because master gets updated so much. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
My perl fu is not so strong (I'm trying to learn concepts of Mojoicious), but I can help a lot with my html|css fu (and a little bit of jQuery)
I'm not sure what was initial concept for exception template:
With this in mind I just simplified parts from html, css and jQuery.
It's possible to improve template a lot more.
I hope you like my changes.
As a side note to http://twitter.com/#!/kraih/status/13612648822210560
This feature doesn't work for me. Clicking on "black box" (is this div#showcase) does nothing.
best regards
Kamen