Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let invalid form elements get class="field-with-error..." #539

Closed
wants to merge 1 commit into from
Closed

Let invalid form elements get class="field-with-error..." #539

wants to merge 1 commit into from

Conversation

jhthorsen
Copy link
Member

I think it's better to add class="..." instead of a block element around the input when the validation fail.

@tianon
Copy link
Contributor

tianon commented Sep 28, 2013

I believe you meant for the commit and issue title to say class="...", not style="..." - the code is using class, anyhow.

@jhthorsen
Copy link
Member Author

@tianon: Yes, of course :(

@kraih
Copy link
Member

kraih commented Sep 28, 2013

Applied in slightly different form. a253f44

@kraih kraih closed this Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhthorsen @tianon @kraih