smarter number and string detection for Mojo::JSON #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it might not work on Perl 5.10 and 5.12, we'll have to fix that first. |
|
And fixed, it's also a little bit faster now at 28.161 seconds. |
kraih
added a commit
that referenced
this pull request
May 12, 2014
smarter number and string detection for Mojo::JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is a lot more DWIM and can handle a few more edge cases than our current
Bbased code, such as dualvars and strings that have accidentally been used in numeric context. Only downside is that it needs to do more copies and is therefore a little slower. For example 100000 iterations ofencode_json({foo => "bar" x 20000, baz => 23})went from 27.398 to 29.621 seconds. I think a vote will have to decide if the change is worth it.