Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell GitHub our test files are Perl 5, not Perl 6 #804

Closed

Conversation

zoffixznet
Copy link
Contributor

This fixes incorrect reporting by GitHub that our repo's test files are written in Perl 6:
perl6

@kraih
Copy link
Member

kraih commented Jun 4, 2015

Not sure about this. I feel like this is really GitHub's problem and they should just be doing a better job with detecting languages.

@kraih
Copy link
Member

kraih commented Jun 4, 2015

Has this actually been reported to GitHub as a bug yet?

@zoffixznet
Copy link
Contributor Author

I see two closed tickets 2074 and 2149 that cover the issue.

Since .t can mean both Perl5 or Perl6, Linguist does some heuristics to figure out which language it is, and since the two languages are similar, in this case it's failing.

Adding a perl shebang, adding use strict;, or adding use v5.XXX will fix it, and another solution provided in the answer to why the issue likely won't be fixed is to use .gitattributes file, which is what this PR has done.

@kraih
Copy link
Member

kraih commented Jun 4, 2015

I've commented on one of the issues. github-linguist/linguist#2149 (comment)

@kraih
Copy link
Member

kraih commented Jun 4, 2015

Clear 👎 from me. This is a problem that needs to be solved in Linguist (not just for us, but for the entire Perl community). Also, the workaround doesn't appear to work for syntax highlighting either.

@zoffixznet
Copy link
Contributor Author

You know what, the discussion here, on IRC, and reading the Linguist tickets actually changed my mind about this PR as well, since this isn't the first time I'm forced to add .gitattributes (here, here, and here).

I agree popularity of a language should be factored into Linguist's heuristics and we shouldn't mindlessly work around a problem in the tools. The tools need to be fixed.

👎

@zoffixznet zoffixznet closed this Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants