Fixed a number of errorprone warnings

mokies · May 19, 2018 · 1a1b17c · 1a1b17c
1 parent 3ff29da
commit 1a1b17c
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 0 deletions.
diff --git a/ratelimitj-dropwizard/src/main/java/es/moki/ratelimij/dropwizard/RateLimitBundle.java b/ratelimitj-dropwizard/src/main/java/es/moki/ratelimij/dropwizard/RateLimitBundle.java
@@ -75,6 +75,7 @@ protected Factory<RequestRateLimiterFactory> createValueFactory(final Parameter
                 return null;
             } else {
                 return new AbstractContainerRequestValueFactory<RequestRateLimiterFactory>() {
+                    @Override
                     public RequestRateLimiterFactory provide() {
                         return requestRateLimiterFactory;
                     }

diff --git a/...wizard/src/test/java/es/moki/ratelimij/dropwizard/component/app/RateLimitApplication.java b/...wizard/src/test/java/es/moki/ratelimij/dropwizard/component/app/RateLimitApplication.java
@@ -24,6 +24,7 @@ public class RateLimitApplication extends Application<Configuration> {
 
     private RedisClient redisClient;
 
+    @Override
     public void initialize(Bootstrap<Configuration> bootstrap) {
         redisClient = RedisClient.create("redis://localhost");
         RequestRateLimiterFactory factory = new RedisRateLimiterFactory(redisClient);

diff --git a/...ard/src/test/java/es/moki/ratelimij/dropwizard/filter/RateLimit429EnforcerFilterTest.java b/...ard/src/test/java/es/moki/ratelimij/dropwizard/filter/RateLimit429EnforcerFilterTest.java
@@ -126,6 +126,7 @@ protected Factory<?> createValueFactory(final Parameter parameter) {
                 return null;
             } else {
                 return new AbstractContainerRequestValueFactory<RequestRateLimiterFactory>() {
+                    @Override
                     public RequestRateLimiterFactory provide() {
                         return requestRateLimiterFactory;
                     }

diff --git a/...ain/java/es/moki/ratelimitj/inmemory/concurrent/InMemoryConcurrentRequestRateLimiter.java b/...ain/java/es/moki/ratelimitj/inmemory/concurrent/InMemoryConcurrentRequestRateLimiter.java
@@ -68,6 +68,7 @@ public boolean hasAcquired() {
             return acquired;
         }
 
+        @Override
         public <T> Optional<T> get(Supplier<T> action) {
             if (!acquired) {
                 return Optional.empty();

diff --git a/ratelimitj-redis/src/test/java/es/moki/ratelimitj/redis/request/RedisScriptLoaderTest.java b/ratelimitj-redis/src/test/java/es/moki/ratelimitj/redis/request/RedisScriptLoaderTest.java
@@ -24,6 +24,7 @@ static void beforeAll() {
     }
 
     @AfterAll
+    @SuppressWarnings("FutureReturnValueIgnored")
     static void afterAll() {
         client.shutdownAsync();
     }

diff --git a/.../java/es/moki/ratelimitj/redis/request/RedisSlidingWindowAsyncRequestRateLimiterTest.java b/.../java/es/moki/ratelimitj/redis/request/RedisSlidingWindowAsyncRequestRateLimiterTest.java
@@ -25,6 +25,7 @@ static void beforeAll() {
     }
 
     @AfterAll
+    @SuppressWarnings("FutureReturnValueIgnored")
     static void afterAll() {
         client.shutdownAsync();
     }

diff --git a/...va/es/moki/ratelimitj/redis/request/RedisSlidingWindowReactiveRequestRateLimiterTest.java b/...va/es/moki/ratelimitj/redis/request/RedisSlidingWindowReactiveRequestRateLimiterTest.java
@@ -25,6 +25,7 @@ static void beforeAll() {
     }
 
     @AfterAll
+    @SuppressWarnings("FutureReturnValueIgnored")
     static void afterAll() {
         client.shutdownAsync();
     }

diff --git a/...t/java/es/moki/ratelimitj/redis/request/RedisSlidingWindowSyncRequestRateLimiterTest.java b/...t/java/es/moki/ratelimitj/redis/request/RedisSlidingWindowSyncRequestRateLimiterTest.java
@@ -26,6 +26,7 @@ static void beforeAll() {
     }
 
     @AfterAll
+    @SuppressWarnings("FutureReturnValueIgnored")
     static void afterAll() {
         client.shutdownAsync();
     }

diff --git a/...elimitj/redis/request/RedisSlidingWindowSyncRequestRequestRateLimiterPerformanceTest.java b/...elimitj/redis/request/RedisSlidingWindowSyncRequestRequestRateLimiterPerformanceTest.java
@@ -25,6 +25,7 @@ static void beforeAll() {
     }
 
     @AfterAll
+    @SuppressWarnings("FutureReturnValueIgnored")
     static void afterAll() {
         client.shutdownAsync();
     }

diff --git a/ratelimitj-redis/src/test/java/es/moki/ratelimitj/redis/time/RedisTimeSupplierTest.java b/ratelimitj-redis/src/test/java/es/moki/ratelimitj/redis/time/RedisTimeSupplierTest.java
@@ -20,6 +20,7 @@ static void beforeAll() {
     }
 
     @AfterAll
+    @SuppressWarnings("FutureReturnValueIgnored")
     static void afterAll() {
         client.shutdownAsync();
     }