fix(molgenis-components): null-check for expressions when a field is emptied after being filled #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svandenhoek
changed the title
svandenhoek
changed the title
chinook25
reviewed
Sep 9, 2024
| @@ -52,6 +52,10 @@ let props = defineProps({ | |||
|
|
|||
| const emit = defineEmits(["update:modelValue"]); | |||
|
|
|||
| function updateModelValue(value) { | |||
| emit("update:modelValue", value == "" ? null : value); | |||
There was a problem hiding this comment.
Please use === instead of ==
chinook25
reviewed
Sep 9, 2024
apps/molgenis-components/src/components/forms/InputHyperlink.vue
Outdated
Show resolved
Hide resolved
|
Included |
|
chinook25
requested changes
Oct 11, 2024
Comment on lines
+229
to
+233
| export function updateModelValue(object, value) { | ||
| updateModelValueEmit(object.$emit, value); | ||
| } | ||
|
|
||
| export function updateModelValueEmit(emit, value) { |
There was a problem hiding this comment.
- These contain ts errors (implicit any type). Do you have your IDE setup correctly? It should show red lines on these functions.
- Is it possible to pass this.$emit into the second function? In that case we could remove the first.
- This comment should not be here, comments double the maintenance of code so should be used only if really necessary.
- I suggest renaming the function to better reflect what they do e.g.
emitModelValueNullSafe
|
This PR is closed in favor of #4353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
Fixed a bug where empty value validation was bugged. Once a field is filled, it cannot be put back into its original (
value is null) state. Similar to #3933.Example:
Schermopname.2024-09-05.om.18.54.56.mov
To be more specific, if having a table with 2 columns (
c1&c2), wherec2can only be filled ifc1is empty, different code would give different errors:c1 == null-> only worked as long asc1is empty, if filled and emptied again the error message would remainc1.length === 0-> only worked AFTER value was set and then emptied, but when trying to save give the errorUpdate into table 'test' failed.: Transaction failed: script failed: TypeError: Cannot read property 'length' of nullc1 == null || c1.length === 0-> works but uglyThis PR should address the issue above and make
<colName> == nullalways usable. It fixes InputString, InputText, InputEmail, InputHyperlink & InputPassword.Only
InputStringwas tested manually with validation string in an actual database table. Other ones have e2e tests to see if value is set tonullif empty input field.how to test:
validationfor a column,<colName> == nullshould now work correctly. F.e. http://localhost:8080/apps/molgenis-components/#/component/InputString and checking ifvalueis removed (null) when field is empty.todo: