Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations from weblate #2178

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

Monero-Weblate
Copy link

Bulk of French translations from multiple contributors, but also translations for Turkish and Chinese

Bulk of French translations from multiple contributors, but
also translations for Turkish and Chinese

Co-authored-by: chatonmars <github-chatonmars.rk7o4@simplelogin.com>
Co-authored-by: cmnt-serge <serge.comont7@gmail.com>
Co-authored-by: Ken Natler <kentnatery@protonmail.com>
Co-authored-by: ChristineLagourde <UneGlotteSifflante@proton.me>
Co-authored-by: Tomamichel Lucas <lucas.tomamichel@gmail.com>
Co-authored-by: fpradal1 <fabrice@pradal.email>
Co-authored-by: Youri <yourisalami1@gmail.com>
Co-authored-by: Alex <alexandrev.v@yandex.com>
Co-authored-by: Youri <yourisalami1@gmail.com>
Co-authored-by: HardenedSteel <HardenedSteel@protonmail.com>
Co-authored-by: Cemal Mert <detherminal@protonmail.com>
Co-authored-by: turgay dogru <turgaydogru@gmail.com>
Co-authored-by: birikibinli <12binli@protonmail.com>
Co-authored-by: Winslow Hee <i@winsloweric.cn>
Co-authored-by: Ken Natler <kentnatery@protonmail.com>
Co-authored-by: BAoDXmA <getmonero.j0f7l@simplelogin.com>
Co-authored-by: ChristineLagourde <UneGlotteSifflante@proton.me>
Co-authored-by: cmnt-serge <serge.comont7@gmail.com>
Co-authored-by: heriotza <lp2@tuta.io>
Co-authored-by: Ken Natler <kentnatery@protonmail.com>
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e785184
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/6489d704ea9c0a0008d4b9b6
😎 Deploy Preview https://deploy-preview-2178--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@plowsof
Copy link
Collaborator

plowsof commented Jul 22, 2023

are we removing the @canonically-unique-host place holders from Moneropedia -> Locally-unique host also? (or the entire guide)

@@ -89,7 +90,7 @@ home:
confidentialité et avec des frais minimes, contre des biens ou des services. Nombre
d'entités acceptent le Monero (XMR), regardez notre liste de commerçants qui
acceptent actuellement le Monero.
useit: "C'est une monnaie : utilisez-la !"
useit: "C'est une monnaie; Utilisez-la !"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
useit: "C'est une monnaie; Utilisez-la !"
useit: "C'est une monnaie; Utilisez-la!"

maybe not an issue but i noticed the "!" on a new line because of screen width and at least some other translations of no space between the "!"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In French they put a space before question and exclamation marks, but i don't think it's an issue if it's inconsistent here and there. More annoying to have the ! in a newline, but doesn't worth changing structure because of it. Will look what can be done.

@plowsof
Copy link
Collaborator

plowsof commented Jul 22, 2023

noticed an @démon under Documentation RPC on the french dev guides page https://deploy-preview-2178--barolo-time-757cf9.netlify.app/fr/resources/developer-guides/index.html

after taking a look - the french translations seem to have all been applied

@erciccione
Copy link
Contributor

are we removing the @canonically-unique-host place holders from Moneropedia -> Locally-unique host also? (or the entire guide)

We can do it independently from this PR. It's better to not manually touch strings coming from Weblate

@luigi1111 luigi1111 merged commit 6199bbd into monero-project:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants