Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-5899): remove unneeded stats from benchmark results #646

Merged
merged 9 commits into from
Feb 9, 2024
Merged

ci(NODE-5899): remove unneeded stats from benchmark results #646

merged 9 commits into from
Feb 9, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Feb 8, 2024 •
edited
Loading

Description

What is changing?

  • Only upload mean throughputs when reporting statistics with perf.send
  • Allow for easier running of benchmarks using local copy of bson
  • Update benchmark README with instructions on how to run benchmarks locally
Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-5899

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title remove extra stats from spec benchmarks ci(NODE-5899): remove unneeded stats from benchmark results Feb 8, 2024
@W-A-James W-A-James marked this pull request as ready for review February 9, 2024 15:25
@nbbeeken nbbeeken self-requested a review February 9, 2024 16:10
@nbbeeken nbbeeken self-assigned this Feb 9, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 9, 2024
nbbeeken
nbbeeken approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the trend chart only has averages now, and nice improvement on the env var control!

Will merge when CI finishes.

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 9, 2024
@nbbeeken nbbeeken merged commit e18b774 into main Feb 9, 2024
4 checks passed
@nbbeeken nbbeeken deleted the NODE-5899/remove-misc-stats branch February 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken