[TOOLS-1576] Move defer statements to after err checks. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertclancy
changed the title
|
Can you recreate this rewriting the commit summary to "TOOLS-1576 move defer statements to after err checks" |
Arguments to defer are evaluated eagerly, hence should occur after any error response is checked.
robertclancy
force-pushed
the
npe-caused-by-defers
branch
from
b6eaca6
to
cdda814
Compare
markbenvenuto
approved these changes
Dec 12, 2016
|
I've changed the commit title. Does it look ok now? |
gabrielrussell
pushed a commit
that referenced
this pull request
Dec 12, 2016
Arguments to defer are evaluated eagerly, hence should occur after any error response is checked.
gabrielrussell
pushed a commit
that referenced
this pull request
Dec 12, 2016
Arguments to defer are evaluated eagerly, hence should occur after any error response is checked.
|
Thanks for the good work @robertclancy |
gabrielrussell
pushed a commit
that referenced
this pull request
Dec 14, 2016
This reverts commit 99e4bd2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments to defer are evaluated eagerly, hence should occur after any
error response is checked.
Fixes https://jira.mongodb.org/browse/TOOLS-1576