INTMDB-630: [CFN - PI] Update backup schedule to move the read-only property from definitions to the properties path #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty from definitions to the properties path
| "/properties/Policies/*/PolicyItems/*/ID", | ||
| "/properties/ProjectId", | ||
| "/properties/ClusterName", | ||
| "/properties/Links" |
There was a problem hiding this comment.
This is the main change
There was a problem hiding this comment.
@andreaangiolillo ProjectId would be input by the user. For now manually fixing it on cdk side.
There was a problem hiding this comment.
fixing it here #414
andreaangiolillo
requested review from
SuperMohit,
Adelmar92 and
govardhanpagidi
govardhanpagidi
approved these changes
Feb 23, 2023
maastha
pushed a commit
that referenced
this pull request
Feb 27, 2023
…roperty from definitions to the properties path (#350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: https://jira.mongodb.org/browse/INTMDB-630
We should update backup schedule to move the read-only property from definitions to the properties path.
See 482
Link to any related issue(s):
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments
I would recommend enabling hide whitespace to review this PR.
