Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-1873 Use OP_MSG to authenticate if the server supports OP_MSG #1116

Merged
merged 15 commits into from
Jan 13, 2022
Merged

DRIVERS-1873 Use OP_MSG to authenticate if the server supports OP_MSG #1116

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b0043dc
initial spec changes
juliusgeo Jan 10, 2022
a3a1fc2
add more version information to CMAP
juliusgeo Jan 10, 2022
7feff3d
added more info to OP_MSG
juliusgeo Jan 10, 2022
7a71034
switch to maxwireversion rather than mongodb version
juliusgeo Jan 10, 2022
0bdfc9c
add a bit more detail to cmap
juliusgeo Jan 10, 2022
e4177fb
fix up wording
juliusgeo Jan 10, 2022
6db224e
fix typos and add .idea to gitignore
juliusgeo Jan 10, 2022
d23105c
make both changes more succinct, change pseudocode
juliusgeo Jan 11, 2022
9d546a4
fix order
juliusgeo Jan 11, 2022
495f8ae
fix typo
juliusgeo Jan 11, 2022
2cbe4f6
switch from cmap to auth spec
juliusgeo Jan 12, 2022
3418b38
update spec version, add changelog entry, bump last modified date
juliusgeo Jan 13, 2022
a429fb5
fix typo
juliusgeo Jan 13, 2022
19dbe13
clarify that authentication messages cannot use compression
juliusgeo Jan 13, 2022
7d7ef63
MUST not -> MUST NOT
juliusgeo Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix up wording
  • Loading branch information
@juliusgeo
juliusgeo committed Jan 10, 2022
commit e4177fb4b05005daa910de37a47fa0c9b21f9028
5 changes: 3 additions & 2 deletions source/connection-monitoring-and-pooling/connection-monitoring-and-pooling.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,9 @@ use ``OP_MSG``(``maxWireVersion >= 6``) or ``OP_QUERY``(``maxWireVersion <6``)
for future communications), handling OP_COMPRESSED, and performing
authentication. It is necessary to inspect the value of ``maxWireVersion``
because starting with MongoDB 6.0 using ``OP_QUERY`` for anything other than
the handshake will result in an error. ``OP_QUERY`` should only be used with
nodes that do not support ``OP_MSG``.
the handshake will result in an error. Once the driver has performed the
handhake and inspected the value of ``maxWireVersion`` it MUST use
``OP_MSG`` if supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the section in the OP_MSG spec instead of duplicating it? Alternatively, I would be more open to duplicating here once we make it more succinct (following my comment in OP_MSG). Or could we just remove this section altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reduced it down significantly because the pseudocode offers some of the details


.. code::

Expand Down