Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove call to https://fonts.googleapis.com #5025

Closed
ghost opened this issue Apr 4, 2021 · 4 comments
Closed

remove call to https://fonts.googleapis.com #5025

ghost opened this issue Apr 4, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 4, 2021

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is.

Describe the solution you'd like

  • Please include CSS in the code so no need to connect to internet for any type of requests.

Thank you for your help.

@ghost ghost changed the title remove call to https://fonts.googleapis.com/css?family=Open Sans remove call to https://fonts.googleapis.com Apr 4, 2021
@mgrhm
Copy link

mgrhm commented Apr 5, 2021

I've opened pull #5027 to remove two instances where Google Fonts are called. These are the only two 'Monica native' occurrences of Google Fonts.

I can see several instances of Google Fonts being called in Laravel and other vendor packages, but I haven't removed those. I think that they'd need to be removed upstream on the package's master branch then merged into Monica from there.

@ghost
Copy link
Author

ghost commented Apr 5, 2021

@mgrhm Thanks.

@asbiin
Copy link
Member

asbiin commented Apr 29, 2021

Fixed by #5027

@asbiin asbiin closed this as completed Apr 29, 2021
@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants