style: Remove google fonts (addresses #5025). #5027
Conversation
|
I'm curious why we need to remove these google fonts. Security / load speed? |
|
In their original request, @krswin said it's important that their Monica instance doesn't connect to the internet for any types of requests. I'd assume that they're hosting it locally and don't want Monica making HTTP calls outside their local network. From my perspective, I can't see a good reason why these are included. They don't improve the site's function (they're barely used), they add to load time, and they're making requests to Google's servers. I don't see a benefit to any of those -- and I'd say removing Google from an application I self-host is a plus. In this pull, I'm removing Google Fonts from an error page. The page works just fine, and will load faster, without that additional overhead. Self-hosting webfonts is a bit fiddly to set up, but not that difficult really. If it's something that Monica wants/needs, we should add the fonts and code so that they're hosted and served locally. As it stands, though, Monica's font-stack is pretty thorough and doesn't rely on non-system fonts. |
|
Makes sense! Thanks for explaining. Definitely in favor of this! |
Co-authored-by: Alexis Saettler <alexis@saettler.org>
|
Thank you @mgrhm |
|
🎉 This PR is included in version 2.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
No description provided.