fix(security): Security Fix for HTML injection to Stored XSS - huntr.dev #4443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://huntr.dev/users/Mik317 has fixed the HTML injection to Stored XSS vulnerability 🔨. Mik317 has been awarded $25 for fixing the vulnerability through the huntr bug bounty program 💵. Think you could fix a vulnerability like this?
Get involved at https://huntr.dev/
Q | A
Version Affected | ALL
Bug Fix | YES
Original Pull Request | 418sec#1
Vulnerability README | https://github.com/418sec/huntr/blob/master/bounties/other/monica/1/README.md
User Comments:
Bounty URL: https://www.huntr.dev/bounties/1-other-monica/
⚙️ Description *
The
monica
CMS is vulnerable againststored-XSS
which occurred when creating anew journal
which was then shown😄
💻 Technical Description *
I added a
server-side
strict check tohtml encode in entities
everyHTML tag
which is inserted inside thepost body
akaentry
. I used thehtmlentities()
to accomplish this task, and I modified also theedit
action in order to avoidbypasses
😄🐛 Proof of Concept (PoC) *
Add a journal entry
buttontitle
andcontent
the following value:<img src="x" onerror=alert(1)>
Save
Journal list
page🔥 Proof of Fix (PoF) *
Same steps with fixed version:
👍 User Acceptance Testing (UAT)
All OK and tested for bypasses 👍