Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add APP_URL to Heroku template #4736

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Conversation

quentinms
Copy link

@quentinms quentinms commented Dec 23, 2020

This should make it easier for people using Heroku for their emails to link to their app instead of the default URL (http://localhost).

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2020

CLA assistant check
All committers have signed the CLA.

@asbiin
Copy link
Member

asbiin commented Dec 31, 2020

OK good. However, the value of the url can only be known after deployment.

@asbiin asbiin changed the title Add APP_URL to Heroku template docs: add APP_URL to Heroku template Dec 31, 2020
@asbiin asbiin merged commit e266629 into monicahq:master Dec 31, 2020
@asbiin
Copy link
Member

asbiin commented Dec 31, 2020

@quentinms Thank you!

@github-actions
Copy link

github-actions bot commented Jan 1, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants