-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add date of creation in journal #4949
Conversation
update forked repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sktlmarat !
There is some adaptation to make so it can be translated a better way, see my suggestions.
resources/js/components/journal/partials/JournalContentEntry.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Thank you @asbiin for your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there ! :)
resources/js/components/journal/partials/JournalContentEntry.vue
Outdated
Show resolved
Hide resolved
resources/js/components/journal/partials/JournalContentEntry.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexis Saettler <alexis@saettler.org>
🎉 This PR is included in version 2.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request has been automatically locked since there |
This feature for #4508
Added created at time on the journal entry (on UI and on the resource for journal entry).
The date on UI looks like this: