Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contact soft delete and prunable #5826

Merged
merged 22 commits into from
Jan 9, 2022
Merged

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Jan 2, 2022

This will fix #5815
It also fix a major break: photos and document file deletion while the model is deleted.

Softdelete on contacts aims at having a list of deleted contacts on carddav to let other systems synchronize the deletion on their own.

@asbiin asbiin requested a review from djaiss January 6, 2022 06:33
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

93.2% 93.2% Coverage
0.0% 0.0% Duplication

Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me mate!

@asbiin asbiin merged commit 6f887df into master Jan 9, 2022
@asbiin asbiin deleted the 20220103-contact-softdelete branch January 9, 2022 18:10
@github-actions
Copy link

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact not deleted with CardDAV on monica
3 participants