Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac Catalyst, use frameworks and move things into the gn files (develop edition) #1681

Merged
merged 15 commits into from
Apr 13, 2021

Conversation

mattleibow
Copy link
Contributor

Description of Change

This PR is adding Mac Catalyst builds and also moves a few basic defines into the gn files to avoid the need for the values to be in the cake files.

At this time, I can't test Mac Catalyst because of xamarin/xamarin-macios#11061 but the iOS changes seem to not affect anything.

Bugs Fixed

None.

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow changed the base branch from main to develop April 3, 2021 00:38
@mattleibow mattleibow changed the title Add Mac Catalyst and move things into the gn files (develop edition) Add Mac Catalyst, use frameworks and move things into the gn files (develop edition) Apr 13, 2021
@mattleibow mattleibow merged commit 1a7b9c7 into develop Apr 13, 2021
@mattleibow mattleibow deleted the dev/maccat-frameworks branch April 13, 2021 03:27
@mattleibow mattleibow added this to the v2.88.0 milestone May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant