Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the WPF backend for Xamarin.Forms #917

Merged
merged 28 commits into from
Jul 26, 2019
Merged

Add the WPF backend for Xamarin.Forms #917

merged 28 commits into from
Jul 26, 2019

Conversation

mattleibow
Copy link
Contributor

Description of Change

Add the WPF backend for Xamarin.Forms.

Bugs Fixed

API Changes

Added the SKCanvasView and SKGLView views.

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow mentioned this pull request Jul 24, 2019
Closed
@mattleibow
Add a Forms WPF NuGet and preview samples
1269a93
@mattleibow
We only have one platform: net461
e925a30
@mattleibow
Add the WPF backend for Xamarin.Forms
d0eedb8
@mattleibow
Fix the nuget packages
c72a8d0 
- add the correct dependencies
- add a targets file to warn if the platform packages were not installed
@mattleibow
Update the samples' readmes
103f1e7
@mattleibow
Echo tizen
7fcb3d2
@mattleibow
More tests
3b58b29
@mattleibow
Revert to test again...
caa316a
@mattleibow
Do publishing better
66b8f05
@mattleibow
try this...
d698f68
@mattleibow
Revert
df959da
@mattleibow
Test again
324036e
@mattleibow
add display name
b37c859
@mattleibow
Only 1 dash...
50d9cd0
@mattleibow
Use build artifacts everywhere
998752c
@mattleibow
This doesn't seem to help...
9d5e5dd
@mattleibow
Copy the files to the correct places
0f848c8
@mattleibow
Revert "This doesn't seem to help..."
dbc4c27 
This reverts commit 9d5e5dd.
@mattleibow
Revert "Revert "This doesn't seem to help...""
e73daab 
This reverts commit dbc4c27.
@mattleibow
Revert "Revert "Revert "This doesn't seem to help..."""
401e854 
This reverts commit e73daab.
@mattleibow
copy the items individually
c8069ae
@mattleibow
Sigh
fb0dbd7
@mattleibow
Just disable tizen for Windows
22f61df 
we are down to 1: linux. Don't fail us!
@mattleibow
Bump tizen to 3.3!
9e3ac7f
@mattleibow
Tizen is broke all over, use Linux
d885331
@mattleibow
nugets are special
a45d128
@mattleibow mattleibow changed the title Add the initial WPF backend Add the WPF backend for Xamarin.Forms Jul 26, 2019
@mattleibow mattleibow merged commit e6b7934 into master Jul 26, 2019
@mattleibow mattleibow deleted the dev/forms-wpf branch July 26, 2019 13:05
@entdark
Copy link

entdark commented Jul 26, 2019

Nice addition, thank you.
Are you going to do anything with the hardcoded FPS problem in SKGLView?

@mattleibow
Copy link
Contributor Author

Are you talking about the hardcoded 60 fps? The other platforms have a 60 fps already, so this is to be consistent.

If there was a way to control the framerate, what would you use? What are your thoughts on just disabling the loop and using your own timer?

@entdark
Copy link

entdark commented Jul 27, 2019

Yes, about the hardcoded 60 fps.
I think using own timer is not a perfect but good idea.
Using OpenTK way where they set custom frequency with extra property is a better solution.

@mattleibow mattleibow added this to Done in v1.68.1 Nov 21, 2019
@mattleibow mattleibow added this to the v1.68.1 milestone Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.68.1
  
Done
Milestone
v1.68.1
Development

Successfully merging this pull request may close these issues.

Add a WPF renderer for Xamarin.Forms
2 participants
@mattleibow @entdark