Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore keys with ignoreKeys #17

Closed
wants to merge 1 commit into from
Closed

Add ability to ignore keys with ignoreKeys #17

wants to merge 1 commit into from

Conversation

martincik
Copy link

No description provided.

@monojack
Copy link
Owner

monojack commented Mar 6, 2019

Hi! Nice option!

Unfortunately, this won't work with nested types. To expand on your example test - if you were to have a neighbours field of type [User] on the Address type, it would not normalize the users - which may be relevant in many scenarios.

I'd be happy to merge if if you would 'fix' this issue.

@martincik
Copy link
Author

@monojack Hey, we actually this was just an exercise for me to think about solutions. We decided not to do use it as you've pointed out it's just not good enough solution. Yet, I think it would be very useful if you could accept nested types but I don't know how to design a good solution.

@martincik martincik closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants